if0ne commented on code in PR #3714:
URL: https://github.com/apache/arrow-adbc/pull/3714#discussion_r2528569700
##########
rust/core/src/non_blocking.rs:
##########
@@ -19,48 +19,45 @@ use arrow_array::{RecordBatch, RecordBatchReader};
use arrow_schema::Schema;
use std::collections::HashSet;
-use std::future::Future;
use crate::error::Result;
use crate::options::{self, *};
use crate::PartitionedResult;
/// Ability to configure an object by setting/getting options.
-pub trait AsyncOptionable {
- type Option: AsRef<str> + Send;
+#[trait_variant::make(AsyncOptionable: Send)]
Review Comment:
> Can we stay with the `impl Future<..>` approach or whatever is done
automatically by this macro to avoid taking in the dependency in adbc_core?
I think we can get rid of the dependency. We’ll have to maintain three
versions of the traits. Maybe someday we’ll live to see
https://github.com/rust-lang/rust/issues/109417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
