if0ne commented on code in PR #3714: URL: https://github.com/apache/arrow-adbc/pull/3714#discussion_r2528601080
########## rust/core/src/blocking.rs: ########## @@ -0,0 +1,793 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: > I think we can skip creating the `blocking` namespace altogether and keep the symbols where they were. "Blocking" has bad connotations and I don't think a blocking database API is as bad as the name "blocking" suggests. I’m a bit confused. @mbrobbel suggests that the async traits should be used by default. To me, this means they should be at the root of the crate, with the corresponding sync version in a separate module. I don’t see anything wrong with using the namespace `blocking`. I relied on existing crates. For example [reqwest](https://docs.rs/reqwest/latest/reqwest/blocking/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
