pitrou commented on code in PR #48414:
URL: https://github.com/apache/arrow/pull/48414#discussion_r2619903552
##########
cpp/src/arrow/array/array_nested.h:
##########
@@ -720,8 +722,8 @@ class ARROW_EXPORT StructArray : public Array {
private:
// For caching boxed child data
- // XXX This is not handled in a thread-safe manner.
- mutable ArrayVector boxed_fields_;
+ struct ARROW_NO_EXPORT Impl;
Review Comment:
I don't remember exactly, but it's done this way [in other instances of the
"pimpl"
idiom](https://github.com/search?q=repo%3Aapache%2Farrow%20ARROW_NO_EXPORT&type=code),
and I assume it's necessary to get compilation to succeed on MSVC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
