h-vetinari commented on code in PR #48414: URL: https://github.com/apache/arrow/pull/48414#discussion_r2621276115
########## cpp/src/arrow/flight/transport/grpc/customize_grpc.h: ########## @@ -20,6 +20,26 @@ #include <limits> #include <memory> +// HACK: Workaround absl::Mutex ABI incompatibility by making sure the Review Comment: Conda-forge compiles add `-DNDEBUG` in `CPP_FLAGS`, and this hasn't changed for a long time. Unfortunately, abseil has a different ABI depending on whether that symbol is defined or not. By using conda-forge compilers it _should_ always be there (making things consistent), but grpc does not seem to respect `CPP_FLAGS` in all circumstances (when I last tested this, it _did_ work when `-DNDEBUG` was part of `CXX_FLAGS` though). Given that it's part of abseil's ABI, which is necessarily baked into the pre-compiled artefacts from conda-forge, there's no option to avoid doing this. Well, that is until https://github.com/abseil/abseil-cpp/commit/18ac60830796f7e7d4a92eec679877de3e44f13c is part of a release and conda-forge has migrated to that version. Not sure if this provides anything new; in any case, #48418 looks like the wrong approach to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
