pitrou commented on code in PR #48414:
URL: https://github.com/apache/arrow/pull/48414#discussion_r2622306693
##########
cpp/src/arrow/array/array_nested.cc:
##########
@@ -1073,11 +1081,16 @@ const ArrayVector& StructArray::fields() const {
for (int i = 0; i < num_fields(); ++i) {
(void)field(i);
}
- return boxed_fields_;
+ return impl_->boxed_fields_;
}
std::shared_ptr<Array> StructArray::field(int i) const {
- std::shared_ptr<Array> result = std::atomic_load(&boxed_fields_[i]);
+ // Atomic ops on std::shared_ptr<T> are deprecated in C++20. They should be
Review Comment:
Yes, but see the rest of the comment you're commenting on :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
