Rich-T-kid commented on code in PR #9936:
URL: https://github.com/apache/arrow-rs/pull/9936#discussion_r3295899370
##########
parquet/benches/arrow_writer.rs:
##########
@@ -363,8 +384,10 @@ fn write_batch_with_option(
bench.iter(|| {
let mut file = Empty::default();
- let mut writer =
- ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone())).unwrap();
+ let Ok(mut writer) = ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone()))
Review Comment:
this makes sense to me, commented out the benchmarks, and included a lint
bypass to pass CI , with a comment linking this discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
