alamb commented on PR #707: URL: https://github.com/apache/arrow-rs-object-store/pull/707#issuecomment-4729299200
> Generally LGTM, codex helped flagged 2 bugs, 1 with azure and another with gcp. And I had a few minor nits. All the changes are in this commit, with corresponding comments explaining the changes: [69a0825](https://github.com/apache/arrow-rs-object-store/commit/69a0825) > > Feel free to take a look and take any that you think is needed. > > The default bundled crypto provider changed from `ring` to `aws-lc-rs`, so maybe we should add "api-change" label Thank you @kevinjqliu I had one question about the no-fips feature flag: https://github.com/kevinjqliu/arrow-rs-object-store/commit/69a0825#r189078918 I also can't but help thinking we may be making things too complicated here by trying to help people use reqwest without one of its built in crypto providers -- I fear in so doing we are going to overfit and people won't actually be able to test with all the feature flags. I have pulled in 69a0825 without the no-fips flag -- thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
