kevinjqliu commented on PR #707: URL: https://github.com/apache/arrow-rs-object-store/pull/707#issuecomment-4731935327
So I added `non-fips` so object_store’s `aws-lc-rs` feature could be used directly with the `*-base` features. Since `object_store` disables `aws-lc-rs` default features, one of `aws-lc-sys`, `non-fips`, or `fips` must be enabled; otherwise `aws-lc-rs` fails to compile. This is whats [breaking CI currently](https://github.com/apache/arrow-rs-object-store/actions/runs/27684854585/job/81882682610?pr=707) when running `cargo clippy --no-default-features --features aws-base,azure-base,gcp-base,http-base,aws-lc-rs -- -D warnings`: ``` Run cargo clippy --no-default-features --features aws-base,azure-base,gcp-base,http-base,aws-lc-rs -- -D warnings cargo clippy --no-default-features --features aws-base,azure-base,gcp-base,http-base,aws-lc-rs -- -D warnings shell: sh -e {0} Compiling aws-lc-rs v1.17.0 Checking rustls-pki-types v1.14.1 error: failed to run custom build command for `aws-lc-rs v1.17.0` Caused by: process didn't exit successfully: `/__w/arrow-rs-object-store/arrow-rs-object-store/target/debug/build/aws-lc-rs-a4641309a02b1d13/build-script-build` (exit status: 101) --- stdout cargo:rustc-check-cfg=cfg(aws_lc_rs_docsrs) cargo:rustc-check-cfg=cfg(disable_slow_tests) cargo:rustc-check-cfg=cfg(dev_tests_only) cargo:rerun-if-env-changed=AWS_LC_RS_DISABLE_SLOW_TESTS cargo:rerun-if-env-changed=AWS_LC_RS_DEV_TESTS_ONLY --- stderr thread 'main' (3575) panicked at /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-rs-1.17.0/build.rs:59:9: one of the following features must be specified: `aws-lc-sys`, `non-fips`, or `fips`. note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace warning: build failed, waiting for other jobs to finish... Error: Process completed with exit code 101. ``` One of the following aws-lc-rs features must be specified: `aws-lc-sys`, `non-fips`, or `fips`. Maybe we should use `aws-lc-rs/aws-lc-sys` instead. This was previously hidden because `reqwest/rustls` pulls in `aws-lc-sys`, but the new CI check exercises `*-base + aws-lc-rs` without `reqwest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
