alamb commented on code in PR #707:
URL:
https://github.com/apache/arrow-rs-object-store/pull/707#discussion_r3430004361
##########
Cargo.toml:
##########
@@ -84,29 +85,36 @@ futures-channel = {version = "0.3", features = ["sink"]}
default = ["fs"]
# Shared cloud/provider implementation dependencies.
-# This intentionally does NOT include reqwest.
-cloud-base = ["serde", "serde_json", "quick-xml", "hyper", "chrono/serde",
"base64", "rand", "ring", "http-body-util", "form_urlencoded",
"serde_urlencoded", "tokio"]
+# This intentionally does NOT include reqwest or a bundled crypto provider.
+cloud-base = ["serde", "serde_json", "quick-xml", "hyper", "chrono/serde",
"base64", "rand", "http-body-util", "form_urlencoded", "serde_urlencoded",
"tokio"]
# Built-in reqwest-based HTTP transport.
reqwest = ["dep:reqwest", "reqwest/stream"]
-# Provider base features.
-# These compile provider logic without forcing reqwest.
+# Bundled crypto providers.
+# Selecting one provides the default `CryptoProvider`; otherwise a custom
+# provider must be supplied at runtime.
+aws-lc-rs = ["dep:aws-lc-rs", "rustls-pki-types"]
Review Comment:
I did this change slightly differently in
https://github.com/apache/arrow-rs-object-store/pull/707/commits/53817ddfa8ed7037388c37968f0aad0ec612b800
I activated it directly on the clippy command line, rather than as part of
the `aws-lc-rs` object store feature (not the dependency)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
