alamb commented on PR #707: URL: https://github.com/apache/arrow-rs-object-store/pull/707#issuecomment-4732460387
> > I also can't but help thinking we may be making things too complicated here by trying to help people use reqwest without one of its built in crypto providers -- I fear in so doing we are going to overfit and people won't actually be able to test with all the feature flags. > > This is actually for users who wants to provide a custom HTTP client instead of `reqwest`. We want `*-base + aws-lc-rs` to be a standalone feature combination; the new CI check catches that case directly. I feel one difference is that actual customers will have their own Cargo.toml file where they can directly activate the features in the subcrates, so they won't be compiling **just** the object_store. So therefore I think the new CI check is invalid as it is verifying something that won't actually be done in practice. After some thought, I think a better way to test these features would be to create some targeted examples that are not part of the workspace and demonstrate (and verify they compile, etc) how to do the various usecases. I will file a follow on ticket to track this work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
