Copilot commented on code in PR #50215:
URL: https://github.com/apache/arrow/pull/50215#discussion_r3435665445
##########
cpp/src/arrow/filesystem/s3_test_util.cc:
##########
@@ -192,6 +192,15 @@ void MinioTestEnvironment::SetUp() {
MakeReadaheadGenerator(std::move(impl_->server_generator_),
pool->GetCapacity());
}
+bool MinioTestEnvironment::IsAvailable() {
+ if (!checked_) {
+ ::arrow::util::Process process;
+ available_ = process.SetExecutable(kMinioExecutableName).ok();
+ checked_ = true;
+ }
+ return available_;
+}
Review Comment:
`MinioTestServer::Start()` supports running against an external
S3-compatible service when
`ARROW_TEST_S3_CONNECT_STRING`/`ARROW_TEST_S3_ACCESS_KEY`/`ARROW_TEST_S3_SECRET_KEY`
are set, which does not require the `minio` executable. With the current
implementation, `IsAvailable()` returns false when `minio` isn't on `PATH`,
causing those externally-configured test runs to be incorrectly skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
