raulcd commented on code in PR #50215:
URL: https://github.com/apache/arrow/pull/50215#discussion_r3440903266
##########
cpp/src/arrow/filesystem/s3fs_module_test.cc:
##########
@@ -55,6 +55,17 @@ MinioTestEnvironment* GetMinioEnv() {
return ::arrow::internal::checked_cast<MinioTestEnvironment*>(minio_env);
}
+class S3ModuleTest : public ::testing::Test {
+ protected:
+ void SetUp() override {
+ if (!GetMinioEnv()->IsAvailable()) {
Review Comment:
isn't this the same as today? We have a check on `cpp_build.sh` where if
MinIO is not on path we exclude the tests and any CI configuration regression
where MinIO is removed from the PATH would not be caught today:
```
if ! type minio >/dev/null 2>&1; then
exclude_tests+=("arrow-s3fs-test")
fi
```
This check would still be required if we split `arrow-s3fs-test` and
`arrow-s3fs-minio-test` unless we manually enforce on CI jobs when tests have
to be skipped, something like a CI flag.
I started working on a split but it's slightly invasive. Given we probably
should migrate MinIO, I'd rather do that on a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
