raulcd commented on PR #50215: URL: https://github.com/apache/arrow/pull/50215#issuecomment-4741794181
@kou @pitrou while working on the S3 module split I've realised we were not testing s3fs tests on macOS due to the unconditional `exclude_tests` on Darwin. I have fixed that and validated they pass for macOS (had to also fix the path discovery). I've also found the current `exclude_tests` approach too broad if MinIO isn't found. We have plenty of tests on `arrow-s3fs-test` that were skipped which don't require MinIO and we are adding more with the `arrow-s3fs-module-test`. I've decided to push a different approach. Add a check on the test fixture to validate whether MinIO is available or not and skip only the tests that require MinIO so the full exclude is not necessary. Let me know what you think. I've validated this locally both ways: without MinIO the non-MinIO tests run and the MinIO dependant ones are skipped, with MinIO on PATH the full suite runs and passes. CI failures are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
