pitrou commented on code in PR #50215:
URL: https://github.com/apache/arrow/pull/50215#discussion_r3435986284
##########
cpp/src/arrow/filesystem/s3fs_module_test.cc:
##########
@@ -55,6 +55,17 @@ MinioTestEnvironment* GetMinioEnv() {
return ::arrow::internal::checked_cast<MinioTestEnvironment*>(minio_env);
}
+class S3ModuleTest : public ::testing::Test {
+ protected:
+ void SetUp() override {
+ if (!GetMinioEnv()->IsAvailable()) {
Review Comment:
This also means that any CI configuration regression where Minio is not on
PATH would not be caught by the test suite. We can perhaps live with that, but
it makes our setup a bit more fragile than previously.
##########
cpp/src/arrow/filesystem/s3_test_util.h:
##########
@@ -74,6 +74,12 @@ class MinioTestEnvironment : public ::testing::Environment {
Result<std::shared_ptr<MinioTestServer>> GetOneServer();
+ bool IsAvailable();
+
+ private:
+ bool checked_ = false;
+ bool available_ = false;
Review Comment:
Can perhaps make this a single `std::optional<bool>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
