lidavidm commented on code in PR #4486:
URL: https://github.com/apache/arrow-adbc/pull/4486#discussion_r3547751927
##########
go/adbc/driver/flightsql/flightsql_adbc_test.go:
##########
@@ -316,6 +317,56 @@ func TestADBCFlightSQL(t *testing.T) {
suite.Run(t, &DomainSocketTests{db: db})
}
+func TestFlightSQLTracingProducesTraceFiles(t *testing.T) {
+ db, err := sql.Open("sqlite",
fmt.Sprintf("file:%s-%d?mode=memory&cache=private", strings.ToLower(t.Name()),
time.Now().UnixNano()))
+ require.NoError(t, err)
+ defer func() { require.NoError(t, db.Close()) }()
Review Comment:
There's already infra for this above (see TestADBCFlightSQL)
##########
go/adbc/driver/flightsql/flightsql_adbc_test.go:
##########
@@ -316,6 +317,56 @@ func TestADBCFlightSQL(t *testing.T) {
suite.Run(t, &DomainSocketTests{db: db})
}
+func TestFlightSQLTracingProducesTraceFiles(t *testing.T) {
+ db, err := sql.Open("sqlite",
fmt.Sprintf("file:%s-%d?mode=memory&cache=private", strings.ToLower(t.Name()),
time.Now().UnixNano()))
+ require.NoError(t, err)
+ defer func() { require.NoError(t, db.Close()) }()
+
+ q := &FlightSQLQuirks{db: db}
+ drv := q.SetupDriver(t)
+ defer q.TearDownDriver(t, drv)
+
+ traceDir := t.TempDir()
+ opts := q.DatabaseOptions()
+ opts[adbc.OptionKeyTelemetryTracesExporter] =
string(adbc.TelemetryExporterAdbcFile)
+ opts[adbc.OptionKeyTelemetryTracesFolderPath] = traceDir
+
+ adbcDB, err := drv.NewDatabase(opts)
+ require.NoError(t, err)
+
+ cnxn, err := adbcDB.Open(context.Background())
+ require.NoError(t, err)
+
+ stmt, err := cnxn.NewStatement()
+ require.NoError(t, err)
+ require.NoError(t, stmt.SetSqlQuery("SELECT 1"))
+
+ reader, _, err := stmt.ExecuteQuery(context.Background())
+ require.NoError(t, err)
+ for reader.Next() {
+ }
+ reader.Release()
+
+ validation.CheckedClose(t, stmt)
+ validation.CheckedClose(t, cnxn)
+ validation.CheckedClose(t, adbcDB)
Review Comment:
Shouldn't these be `defer`ed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
