zeroshade commented on code in PR #4486:
URL: https://github.com/apache/arrow-adbc/pull/4486#discussion_r3553779349
##########
go/adbc/driver/flightsql/flightsql_database.go:
##########
@@ -480,7 +481,10 @@ type support struct {
transactions bool
}
-func (d *databaseImpl) Open(ctx context.Context) (adbc.Connection, error) {
+func (d *databaseImpl) Open(ctx context.Context) (cnxn adbc.Connection, err
error) {
+ ctx, span := internal.StartSpan(ctx, "FlightSQLDatabase.Open", d)
+ defer func() { internal.EndSpan(span, err) }()
Review Comment:
should just be
```suggestion
defer internal.EndSpan(span, err)
```
right?
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -530,6 +531,9 @@ func (s *statement) ExecuteQuery(ctx context.Context) (rdr
array.RecordReader, n
}
}
+ ctx, span := internal.StartSpan(ctx, "FlightSQLStatement.ExecuteQuery",
s.cnxn)
+ defer func() { internal.EndSpan(span, err) }()
Review Comment:
```suggestion
defer internal.EndSpan(span, err)
```
##########
go/adbc/driver/flightsql/flightsql_database.go:
##########
@@ -588,11 +592,12 @@ func (d *databaseImpl) Open(ctx context.Context)
(adbc.Connection, error) {
"driver", infoDriverName,
)
- return driverbase.NewConnectionBuilder(conn).
+ cnxn = driverbase.NewConnectionBuilder(conn).
WithDriverInfoPreparer(conn).
WithAutocommitSetter(conn).
WithCurrentNamespacer(conn).
- Connection(), nil
+ Connection()
+ return cnxn, nil
Review Comment:
why this change?
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -602,6 +606,9 @@ func (s *statement) ExecuteUpdate(ctx context.Context) (n
int64, err error) {
}
}
+ ctx, span := internal.StartSpan(ctx,
"FlightSQLStatement.ExecuteUpdate", s.cnxn)
+ defer func() { internal.EndSpan(span, err) }()
Review Comment:
```suggestion
defer internal.EndSpan(span, err)
```
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -647,7 +654,10 @@ func (s *statement) ExecuteUpdate(ctx context.Context) (n
int64, err error) {
// Prepare turns this statement into a prepared statement to be executed
// multiple times. This invalidates any prior result sets.
-func (s *statement) Prepare(ctx context.Context) error {
+func (s *statement) Prepare(ctx context.Context) (err error) {
+ ctx, span := internal.StartSpan(ctx, "FlightSQLStatement.Prepare",
s.cnxn)
+ defer func() { internal.EndSpan(span, err) }()
Review Comment:
```suggestion
defer internal.EndSpan(span, err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
