binarycat-dremio commented on code in PR #4486:
URL: https://github.com/apache/arrow-adbc/pull/4486#discussion_r3554976779
##########
go/adbc/driver/flightsql/flightsql_database.go:
##########
@@ -480,7 +481,10 @@ type support struct {
transactions bool
}
-func (d *databaseImpl) Open(ctx context.Context) (adbc.Connection, error) {
+func (d *databaseImpl) Open(ctx context.Context) (cnxn adbc.Connection, err
error) {
+ ctx, span := internal.StartSpan(ctx, "FlightSQLDatabase.Open", d)
+ defer func() { internal.EndSpan(span, err) }()
Review Comment:
I turned it into "refactoring" issue and left the TODOs. To do not forget to
make it prettier 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
