binarycat-dremio commented on code in PR #4486:
URL: https://github.com/apache/arrow-adbc/pull/4486#discussion_r3551593556
##########
go/adbc/driver/flightsql/flightsql_adbc_test.go:
##########
@@ -316,6 +317,56 @@ func TestADBCFlightSQL(t *testing.T) {
suite.Run(t, &DomainSocketTests{db: db})
}
+func TestFlightSQLTracingProducesTraceFiles(t *testing.T) {
+ db, err := sql.Open("sqlite",
fmt.Sprintf("file:%s-%d?mode=memory&cache=private", strings.ToLower(t.Name()),
time.Now().UnixNano()))
+ require.NoError(t, err)
+ defer func() { require.NoError(t, db.Close()) }()
Review Comment:
Thanks for pointing this.
`example.CreateDB()` was tried, but caused cross-test interference in the
full go test ./driver/flightsql run.
I propose to refactor this in a foolow-up issue/PR
http://github.com/apache/arrow-go/issues/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
