johnwparent opened a new pull request, #50450:
URL: https://github.com/apache/arrow/pull/50450

   ### Rationale for this change
   
   Preventing an invalid argument to be supplied to the MSVC linker, which can 
potentially break arrow builds on paths with spaces on Windows when using MSVC.
   
   ### What changes are included in this PR?
   
   `cpp/CMakeLists.txt` has been updated to add a specific check for the MSVC 
toolchain, and if true, sets `CXX_LINKER_SUPPORTS_VERSION_SCRIPT` to `FALSE`.
   
   ### Are these changes tested?
   
   Yes, see the build of `arrow` in this CI run in Spack's built with this 
patch and a path with a space: 
https://gitlab.spack.io/spack/spack-packages/-/jobs/22970695
   
   ### Are there any user-facing changes?
   
   No
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to