johnwparent commented on code in PR #50450:
URL: https://github.com/apache/arrow/pull/50450#discussion_r3554906519
##########
cpp/CMakeLists.txt:
##########
@@ -362,6 +362,10 @@ if(CMAKE_VERSION VERSION_LESS 3.18)
else()
set(CXX_LINKER_SUPPORTS_VERSION_SCRIPT TRUE)
endif()
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Review Comment:
I let this be the more restrictive condition as I wasn't sure if any "MSVC
like" compilers would support the version file, I'm not aware of any that do,
so I think this suggestion is probably fine, but I'm not aware of the scope of
Arrow's deployment, and just wanted to point out there are side effects from
changing this check beyond terseness, just to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
