kou commented on code in PR #50450:
URL: https://github.com/apache/arrow/pull/50450#discussion_r3554669816
##########
cpp/CMakeLists.txt:
##########
@@ -362,6 +362,10 @@ if(CMAKE_VERSION VERSION_LESS 3.18)
else()
set(CXX_LINKER_SUPPORTS_VERSION_SCRIPT TRUE)
endif()
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Review Comment:
```suggestion
elseif(MSVC)
```
##########
cpp/CMakeLists.txt:
##########
@@ -362,6 +362,10 @@ if(CMAKE_VERSION VERSION_LESS 3.18)
else()
set(CXX_LINKER_SUPPORTS_VERSION_SCRIPT TRUE)
endif()
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+ # msvc does not support version scripts, but check_linker_flag won't return
false
+ # due to how msvc's linker reports unrecognized arguments
Review Comment:
```suggestion
# due to how MSVC's linker reports unrecognized arguments
```
##########
cpp/CMakeLists.txt:
##########
@@ -362,6 +362,10 @@ if(CMAKE_VERSION VERSION_LESS 3.18)
else()
set(CXX_LINKER_SUPPORTS_VERSION_SCRIPT TRUE)
endif()
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+ # msvc does not support version scripts, but check_linker_flag won't return
false
Review Comment:
```suggestion
# MSVC does not support version scripts, but check_linker_flag won't
return false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
