johnwparent commented on PR #50450: URL: https://github.com/apache/arrow/pull/50450#issuecomment-4929646723
> Interesting. > > If we use `LINKER:-version-script=...` instead of `-Wl,--version-script=...`, does `check_linker_flag()` with MSVC report `FALSE`? > > If `check_linker_flag()` with MSVC doesn't report `FALSE` for any flags, I feel that it's a problem of CMake. Could you report it to CMake? It's an inherent behavior of MSVC's linker, but it does look like that module attempts to catch diagnostic output. I'll see if we're interested in a patch. Another question, that I didn't both to ask for Spack, but is relevant to this patch, is do we want to control symbol visibility with MSVC the same way the version script is doing here? In which case we can write a .def or similar file instead of skipping this entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
