prodriguezdefino commented on code in PR #32529:
URL: https://github.com/apache/beam/pull/32529#discussion_r1777921531
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2523,6 +2532,7 @@ def __init__(
use_at_least_once=False,
with_auto_sharding=False,
num_storage_api_streams=0,
+ cdc_writes_with_primary_key: List[str] = None,
Review Comment:
added the callable argument to the constructor.
I was not able to enforce the types for the callable to make sure we are
processing rows (input and output) because the compilation complained about
`beam.Row` not being able to be used as part of the type signature
`Callable[[beam.Row], beam.Row]`:
```
AttributeError: partially initialized module 'apache_beam' has no attribute
'Row' (most likely due to a circular import)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
