prodriguezdefino commented on code in PR #32529:
URL: https://github.com/apache/beam/pull/32529#discussion_r1779330024
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2613,6 +2625,62 @@ def expand(self, input):
# communicate to Java that this write should use dynamic destinations
table = StorageWriteToBigQuery.DYNAMIC_DESTINATIONS
+ use_cdc_writes = False
+ # if CDC functionality is configured we need to check if a callable has
+ # been passed to extract MutationInfo from the rows to be written
+ if callable(self._use_cdc_writes):
Review Comment:
Let me try to have it implemented for both in this change, if you still see
it incomplete I will remove it after the next review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
