scwhittle commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2137700743
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java:
##########
@@ -424,4 +424,16 @@ public String create(PipelineOptions options) {
return String.format("%s/%s", info.getName(),
info.getVersion()).replace(" ", "_");
}
}
+
+ /**
+ * The time limit (minute) that an SDK worker allows for a PTransform
operation before signaling
+ * the runner harness to restart the SDK worker.
+ */
+ @Default.Integer(Integer.MAX_VALUE)
Review Comment:
I think that having zero/default have a special meaning of not enabled makes
sense and is clearer than some arbitrary large duration.
> From the conversation thread for my starter project, seems like they
prefer this option to be a standard pipeline option. I will keep the
implementation for now and see if there is more input
Putting within SdkHarnessOptions is still a pipeline option, it is just
grouped with other sdk specific options. I believe you are referring to the
decision to use a pipeline option instead of a dataflow service option
(https://cloud.google.com/dataflow/docs/reference/service-options) or
experiment (see --experiment here
https://cloud.google.com/dataflow/docs/reference/pipeline-options). I agree
that moving to SdkHarnessOptions seems like a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
