LEEKYE commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2138140738
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -65,6 +66,7 @@ public class ExecutionStateSampler {
private static final Logger LOG =
LoggerFactory.getLogger(ExecutionStateSampler.class);
private static final int DEFAULT_SAMPLING_PERIOD_MS = 200;
private static final long MAX_LULL_TIME_MS = TimeUnit.MINUTES.toMillis(5);
+ private static final int MIN_LULL_TIME_MINUTE_FOR_RESTART = 10; // Open to
change.
Review Comment:
> Is there a reason to enforce a minimum? Low-latency streaming users may
not want this much latency if a restart faster would fix things. If we do want
a minimum I think it could be as low as 10 seconds, or alternatively we could
just not enforce it and it's up to users to not misconfigure things.
In the new fix, I set default timeout to be 0 which means timeout not
enabled. More discussion is needed in terms of how long it is for this timeout
duration setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
