Abacn commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2138626795
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java:
##########
@@ -424,4 +424,16 @@ public String create(PipelineOptions options) {
return String.format("%s/%s", info.getName(),
info.getVersion()).replace(" ", "_");
}
}
+
+ /**
+ * The time limit (minute) that an SDK worker allows for a PTransform
operation before signaling
+ * the runner harness to restart the SDK worker.
+ */
+ @Default.Integer(Integer.MAX_VALUE)
Review Comment:
From user perspective options in `PiplineOptions` or `SdkHarnessOptions` has
no difference. User interface are the same (provide
`--ptransformTimeoutDuration=xxx`) and they both live in SDK core so no
dependency difference either.
ExperimentalOptions or DataflowServiceOptions are different as they need to
set `--experiments=xxx` or `--dataflowServiceOptions=xxx`.
The minor issue that put it into base `PipelineOptions` is that all pipeline
option interface extends `PipelineOptions` and then extends
the`--ptransformTimeoutDuration` field. In general we aim to put pipeline
options into specific interface that extends PipelineOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
