apanich commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2138747223
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -357,6 +390,15 @@ private void takeSample(long currentTimeMillis, long
millisSinceLastSample) {
transitionsAtLastSample = transitionsAtThisSample;
} else {
long lullTimeMs = currentTimeMillis - lastTransitionTimeMillis.get();
+
+ if (userAllowedTimeoutForRestart && lullTimeMs >
userAllowedLullTimeMsForRestart) {
+ throw new RuntimeException(
Review Comment:
pelase throw TimeoutException and then wrap it with RuntimeException
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
Review Comment:
please try this solution with dataflow test to conifrm that when exception
is thrown the sdk is restarted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
