mohamedawnallah commented on code in PR #35216:
URL: https://github.com/apache/beam/pull/35216#discussion_r2172848535


##########
sdks/python/setup.py:
##########
@@ -401,6 +401,8 @@ def get_portability_package_data():
           'typing-extensions>=3.7.0',
           'zstandard>=0.18.0,<1',
           'pyyaml>=3.12,<7.0.0',
+          'pymilvus>=2.5.10,<3.0.0',
+          'setuptools>=80.9.0',

Review Comment:
   Also this is may be unrelated perhaps we no longer need the following 
commands in those docs (given they are optional though):
   
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95653376#PythonTips-OnmacOS/Linux
   
   ```
   ...
   # Upgrade other tools. (Optional)
   pip install --upgrade pip
   pip install --upgrade setuptools
   ...
   ```
   
   We could manage those versions inside `sdks/python/setup.py` instead
   
   I'm not sure where exactly these docs are located, and it's a minor thing 
anyway and not that important



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to