mohamedawnallah commented on code in PR #35216: URL: https://github.com/apache/beam/pull/35216#discussion_r2172839948
########## sdks/python/setup.py: ########## @@ -401,6 +401,8 @@ def get_portability_package_data(): 'typing-extensions>=3.7.0', 'zstandard>=0.18.0,<1', 'pyyaml>=3.12,<7.0.0', + 'pymilvus>=2.5.10,<3.0.0', + 'setuptools>=80.9.0', Review Comment: The `pymilvus` client currently requires `setuptools > 69` as shown in: https://github.com/milvus-io/pymilvus/blob/0195a28ae9de4a38f151aa5f20085eabd6c40c19/pyproject.toml#L23 This dependency requirement varies based on the Python version: - Python 3.9, 3.10, and 3.11: These versions typically include `setuptools` by default. The default versions are similar to the following: - Python 3.9 → `setuptools==58.1.0` - Python 3.10 → `setuptools==65.5.0` - Python 3.11 → `setuptools==65.5.0` These versions don't meet the minimum version requirement for `pymilvus`. - Python 3.12 and 3.13: These versions generally do not include `setuptools` by default, so they need to be installed manually. I found a convenient way of using `--all` flag option along with `pip freeze` when docker image base requirements generated using `generatePythonRequirementsAll` PS: I've also included `pip`. It is not a real dependency for `pymilvus` but it may come in handy. Updating `setuptools` and `pip` is recommended in the following documentation: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95653376#PythonTips-OnmacOS/Linux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org