damccorm commented on code in PR #35216:
URL: https://github.com/apache/beam/pull/35216#discussion_r2175140309
##########
sdks/python/setup.py:
##########
@@ -401,6 +401,8 @@ def get_portability_package_data():
'typing-extensions>=3.7.0',
'zstandard>=0.18.0,<1',
'pyyaml>=3.12,<7.0.0',
+ 'pymilvus>=2.5.10,<3.0.0',
+ 'setuptools>=80.9.0',
Review Comment:
Rather than explicitly pinning setuptools, we can let pymilvus enforce that
constraint. If we install pymilvus, since it requires setuptools, setuptools
should automatically get installed as well.
> I've also included pip. It is not a real dependency for pymilvus but it
may come in handy. Updating setuptools and pip is recommended in the following
documentation:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95653376#PythonTips-OnmacOS/Linux
I think we should avoid doing this. This will cause anyone who installs Beam
to need `pip>=25.1.1` - while we recommend that for developing Beam, we don't
need to require it of anyone who uses Beam (this could cause problems if
another dependency requires a different version of pip for some reason).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
