damccorm commented on code in PR #35216:
URL: https://github.com/apache/beam/pull/35216#discussion_r2175149226
##########
sdks/python/setup.py:
##########
@@ -401,6 +401,8 @@ def get_portability_package_data():
'typing-extensions>=3.7.0',
'zstandard>=0.18.0,<1',
'pyyaml>=3.12,<7.0.0',
+ 'pymilvus>=2.5.10,<3.0.0',
+ 'setuptools>=80.9.0',
Review Comment:
One other thought - I think it would be good to put milvus in its own extra
like we do with tensorflow.
https://github.com/apache/beam/blob/aa2231ff8892a07eddecad14599fa338e6fd6f64/sdks/python/setup.py#L577
If we do this, we'd probably want to have a separate tox suite like we do
with tensorflow -
https://github.com/apache/beam/blob/dd9552cce05f9332c25bfbb454b9f82f92436527/sdks/python/tox.ini#L432
I'd recommend that we do this, but we can handle it in a separate PR (I
think that will be easier)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
