shunping commented on code in PR #36424:
URL: https://github.com/apache/beam/pull/36424#discussion_r2414590805
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -266,9 +266,9 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
// No payload means this coder was length prefixed by the runner
// but is likely self describing - AKA a beam coder.
- if len(sub.GetSpec().GetPayload()) == 0 {
- return b.makeCoder(components[0], sub)
- }
+ // if len(sub.GetSpec().GetPayload()) == 0 {
+ // return b.makeCoder(components[0], sub)
+ // }
// TODO(lostluck) 2018/10/17: Make this strict again, once
dataflow can use
// the portable pipeline model directly (BEAM-2885)
Review Comment:
Added breaking changes in CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
