lostluck commented on code in PR #36424:
URL: https://github.com/apache/beam/pull/36424#discussion_r2411263695
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -277,32 +277,35 @@ func executePipeline(ctx context.Context, wks
map[string]*worker.W, j *jobservic
}
// Ensure awareness of the coder used for the
teststream.
- cID, err := lpUnknownCoders(pyld.GetCoderId(),
coders, comps.GetCoders())
+ // This also adds a LP-coder for the original
coder in comps.
+ cID, err := forceLpCoder(pyld.GetCoderId(),
comps.GetCoders())
Review Comment:
My main concern here is that we aren't preserving the original coder set in
components. That's why things are mostly added to the "coders" map instead.
"coders" is what ultimately goes SDK side per bundle.
The goal with that was to end up with the minimal set of coders to bundles
to make sure SDKs weren't assuming the existence of coders they never told us
about. Eg. making weird cross transform assumptions, or messing something else
up in other transforms, as coders are often shared.
But since it's scoped to TestStream it's probably fine. A TODO is good
enough for now // TODO: Do not mutate component coders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
