shunping commented on code in PR #36424:
URL: https://github.com/apache/beam/pull/36424#discussion_r2414419759
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -277,32 +277,35 @@ func executePipeline(ctx context.Context, wks
map[string]*worker.W, j *jobservic
}
// Ensure awareness of the coder used for the
teststream.
- cID, err := lpUnknownCoders(pyld.GetCoderId(),
coders, comps.GetCoders())
+ // This also adds a LP-coder for the original
coder in comps.
+ cID, err := forceLpCoder(pyld.GetCoderId(),
comps.GetCoders())
Review Comment:
ACK. https://github.com/apache/beam/issues/36440
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -277,32 +277,35 @@ func executePipeline(ctx context.Context, wks
map[string]*worker.W, j *jobservic
}
// Ensure awareness of the coder used for the
teststream.
- cID, err := lpUnknownCoders(pyld.GetCoderId(),
coders, comps.GetCoders())
+ // This also adds a LP-coder for the original
coder in comps.
+ cID, err := forceLpCoder(pyld.GetCoderId(),
comps.GetCoders())
Review Comment:
ACK. Added https://github.com/apache/beam/issues/36440 to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
