lostluck commented on code in PR #36424:
URL: https://github.com/apache/beam/pull/36424#discussion_r2414500348
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -266,9 +266,9 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
// No payload means this coder was length prefixed by the runner
// but is likely self describing - AKA a beam coder.
- if len(sub.GetSpec().GetPayload()) == 0 {
- return b.makeCoder(components[0], sub)
- }
+ // if len(sub.GetSpec().GetPayload()) == 0 {
+ // return b.makeCoder(components[0], sub)
+ // }
// TODO(lostluck) 2018/10/17: Make this strict again, once
dataflow can use
// the portable pipeline model directly (BEAM-2885)
Review Comment:
If the integration tests pass, we can probably delete the newly commented
out code.
There is a correctness risk though around upgrading pipelines WRT in flight
data and stored state.
That is, it would at least need to be able read the old version if the new
version fails, and write only the new one. This may have a correctness issue
though.... So, some concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
