Abacn commented on PR #37728: URL: https://github.com/apache/beam/pull/37728#issuecomment-4026382701
> This only applies when the typehint is beam.Row right? Just want to be sure we arent changing default coders in update incompatible way. Yes, the entrypoint of the change being effective is https://github.com/apache/beam/pull/37728/changes#diff-d31b9184f7423473c4e6deda80b237aa474228143a0bab2faedd9afe2e944982R633 Previously, same config results in TypeError (shown in PR description), therefore no upgrade compatibility concern. There was a change in native_type_compatibility.py added dataclass into type_map that might change typehint of existing dataclasses https://github.com/apache/beam/pull/37728/changes/0aa835dcb2d2b037121cb75ee6dc439f1d364ad0#diff-3f6570dbd8f6850deb466f36b7b7983e9b5c1adaec3810dfe672e108188a35ebR426 Further testing shows this change was actually dead code. Dataclass will hit this branch: https://github.com/Abacn/beam/blob/0aa835dcb2d2b037121cb75ee6dc439f1d364ad0/sdks/python/apache_beam/typehints/native_type_compatibility.py#L393 and return before iterating over type_map. Reverted in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
