claudevdm commented on code in PR #37728:
URL: https://github.com/apache/beam/pull/37728#discussion_r2954800153
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -629,7 +630,7 @@ def schema_from_element_type(element_type: type) ->
schema_pb2.Schema:
Returns schema as a list of (name, python_type) tuples"""
if isinstance(element_type, row_type.RowTypeConstraint):
return named_fields_to_schema(element_type._fields)
- elif match_is_named_tuple(element_type):
+ elif match_is_named_tuple(element_type) or match_is_dataclass(element_type):
Review Comment:
Can we add an update compat version check here?
See
https://github.com/apache/beam/blob/d51177b9cee212cba5d82d968611f328292b8678/sdks/python/apache_beam/coders/coders.py#L1009-L1013
for a global pipeline options view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
