Abacn commented on code in PR #37728:
URL: https://github.com/apache/beam/pull/37728#discussion_r2908908216


##########
sdks/python/apache_beam/typehints/schemas_test.py:
##########
@@ -646,6 +665,48 @@ def test_trivial_example(self):
         expected.row_type.schema.fields,
         typing_to_runner_api(MyCuteClass).row_type.schema.fields)
 
+  def test_trivial_example_dataclass(self):

Review Comment:
   Thanks, added unit tests for both named tuple and dataclasses (they are 
expected to resulting in same generated user type passing through GBK)
   
    Noticing current schemas_test unit tests does not involve pipeline tests. 
Created a row_type_test to settle these tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to