claudevdm commented on code in PR #37728:
URL: https://github.com/apache/beam/pull/37728#discussion_r2908275827
##########
sdks/python/apache_beam/typehints/schemas_test.py:
##########
@@ -646,6 +665,48 @@ def test_trivial_example(self):
expected.row_type.schema.fields,
typing_to_runner_api(MyCuteClass).row_type.schema.fields)
+ def test_trivial_example_dataclass(self):
Review Comment:
What do you think about adding a test that does
beam.Create([MyCuteDataclass()]).wit_output_types(beam.Row) -> Reshuffle (the
results should be named tuples)?
And also a test that
beam.Create([MyCuteDataclass()]).wit_output_types(beam.Row) -> Reshuffle the
resulting type is still the original dataclass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
