Abacn commented on code in PR #39445: URL: https://github.com/apache/beam/pull/39445#discussion_r3634727783
########## sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java: ########## Review Comment: The size of this fix is non-trivial. There are a few concerns - reflection based, generally fragile - It also increases serialized size of pipeline options (seen in Dataflow UI, internal objects, etc). Given that get/setGoogleCloudStorageReadOptions are deprecated and is only effective in GcsUtilV1, I would prefer a smaller fix: - Json Serialize-deserialize options that we want to explicitly expose (Fadvise, etc). On serialization, when it's found not the default, write to encoding. In this way we can avoid reflection and largely reduce the serialization size - If possible, do not leak jackson classes to ApiSurface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
