shunping commented on code in PR #39445: URL: https://github.com/apache/beam/pull/39445#discussion_r3635341116
########## sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java: ########## Review Comment: I made the change to support a subset of options. However, Jackson classes must be included in the `ApiSurface`. This is because `GcsOptions` is a public interface with methods annotated with `@JsonSerialize` and `@JsonDeserialize`. The `JsonDeserialize` annotation declares methods returning `Class<? extends JsonDeserializer>`, which pulls `com.fasterxml.jackson.databind `into the exposed API surface graph. `JsonDeserializer`, in turn, references `JsonParser` and other classes from `com.fasterxml.jackson.core`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
