shunping commented on code in PR #39445: URL: https://github.com/apache/beam/pull/39445#discussion_r3634775254
########## sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java: ########## Review Comment: If our goal is solely to fix the regression caused by the default value of fadvise, we wouldn't need to modify the serialization and deserialization logic for GoogleCloudStorageReadOptions. However, the broader intent of this fix is to address the underlying issue: the inability to propagate `GoogleCloudStorageReadOptions` to remote workers via pipeline options. Regarding the use of reflection, it was chosen to future-proof the implementation. If we explicitly serialize fields instead of using reflection, we will be forced to update our code every time the upstream gcs-connector modifies or adds fields to this class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
