Abacn commented on code in PR #39445:
URL: https://github.com/apache/beam/pull/39445#discussion_r3639352383
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java:
##########
@@ -49,12 +58,19 @@ public interface GcsOptions extends ApplicationNameOptions,
GcpOptions, Pipeline
class GcsReadOptionsFactory implements
DefaultValueFactory<GoogleCloudStorageReadOptions> {
@Override
public GoogleCloudStorageReadOptions create(PipelineOptions options) {
- return GoogleCloudStorageReadOptions.DEFAULT;
+ // In gcs-connector v3, GoogleCloudStorageReadOptions.DEFAULT changed
fadvise from SEQUENTIAL
+ // to AUTO. Beam workloads default to SEQUENTIAL to preserve expected
sequential read
+ // throughput and caching behavior.
+ return GoogleCloudStorageReadOptions.DEFAULT
+ .toBuilder()
+ .setFadvise(GoogleCloudStorageReadOptions.Fadvise.SEQUENTIAL)
+ .build();
Review Comment:
Just return DEFAULT_OPTIONS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
