andygrove commented on PR #340:
URL: https://github.com/apache/datafusion-comet/pull/340#issuecomment-2085669471
As @viirya said, we can handle the difference in error message format in the
scala test (we already have examples of this in the `castTest` method).
For versions prior to 3.4 perhaps you could just check for the word
"overflow" in the error message.
```
- cast short to byte *** FAILED *** (439 milliseconds)
"Execution error: [CAST_OVERFLOW] The value 18716S of the type "SMALLINT"
cannot be cast to "TINYINT" due to an overflow. Use `try_cast` to tolerate
overflow and return NULL instead. If necessary set "spark.sql.ansi.enabled" to
"false" to bypass this error." did not contain "asting 18716 to tinyint causes
overflow" (CometCastSuite.scala:200)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
