andygrove commented on PR #340: URL: https://github.com/apache/datafusion-comet/pull/340#issuecomment-2087678461
> thanks for the inputs @viirya @andygrove , I have added another check in the assert statement where we compare exception messages. Do you think this approach looks good? or do I need to separate the "invalid cast" and "overflow" assert statements. > > If this change is fine, I will modify the code comments to accommodate "overflow" exception aswell. I think this general approach is OK to handle different types of expected errors. I left a specific comment on the code as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
