andygrove commented on code in PR #340:
URL: https://github.com/apache/datafusion-comet/pull/340#discussion_r1585636219
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -722,7 +746,8 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
// Comet message is in format `The value 'VALUE' of the type
FROM_TYPE cannot be cast to TO_TYPE`
// We just check that the comet message contains the same
invalid value as the Spark message
val sparkInvalidValue =
sparkMessage.substring(sparkMessage.indexOf(':') + 2)
Review Comment:
Now that we are handling multiple types of error here, we should probably
check if `sparkMessage.indexOf(':')` returns a non-zero value before trying to
use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
