alamb opened a new issue, #10426: URL: https://github.com/apache/datafusion/issues/10426
### Is your feature request related to a problem or challenge? Part of https://github.com/apache/datafusion/issues/5637 One of the optimizer passes is "common subexpression elimination" that removes redundant computation However, as @peter-toth noted on https://github.com/apache/datafusion/pull/10396 and the CSE code says https://github.com/apache/datafusion/blob/d58bae487329b7a7078429f083bffc611f42c8c7/datafusion/optimizer/src/common_subexpr_eliminate.rs#L108-L119 The way it tracks common subexpressions is with string manipulation is is non ideal for several reasons (including the cost of creating those strings) ### Describe the solution you'd like Revisit the identifiers as using these string identifiers as the keys of `ExprStats` was not the best choice. Please note this is how CSE has been working since the feature was added initially. ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
