alamb commented on issue #10426: URL: https://github.com/apache/datafusion/issues/10426#issuecomment-2113109684
> FWIW I've also seen the high cost of expression string formatting (using `Display`/`to_string()`) in a good number of profiles. > I think there's nothing wrong about having a "display" infrastructure, but it shouldn't be used eagerly. As others pointed out, using a hash or any form of numeric ID would probably be better in many places. 100% -- btw https://github.com/apache/datafusion/pull/10454 from @erratic-pattern made this code faster (fewer allocations) though it would be better still as you point out to not use display as much. I will say from personal experience working on postgres / postgres derived systems (which does use a numeric id to identify columns), using strings is *much* easier to debug when problems occur. I do think we can reduce it significantly however -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
