peter-toth commented on issue #10426: URL: https://github.com/apache/datafusion/issues/10426#issuecomment-2105745741
> I like the idea of generalizing the `(u64, &Expr)` struct into something reuseable across optimizations. Honestly, I don't know the those referenced usecases, but I feel `(u64, &Expr)` (and any `Identifier` in general) makes sense only for CSE (2 traversals, we can build up a preorder visit cache of `Identifier`s in the first traversal and second traversal is top-down) and not sure the others have the same characteristics... If that's not the case then it doesn't make sense to use `Identifiers` instead of `&Expr`. Anyways, I will try to open the PR with it next week and then feel free to generalize the idea for other usecases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
